From f843248215c1f87d732b2aec27b1d30c0ceba163 Mon Sep 17 00:00:00 2001 From: Hiltjo Posthuma Date: Fri, 23 Jun 2017 13:53:46 +0200 Subject: [PATCH] separate getstats from getbyoid: slightly faster --- stagit.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/stagit.c b/stagit.c index d10c88c..3362fe5 100644 --- a/stagit.c +++ b/stagit.c @@ -208,8 +208,6 @@ commitinfo_getbyoid(const git_oid *id) opts.flags |= GIT_DIFF_DISABLE_PATHSPEC_MATCH; if (git_diff_tree_to_tree(&(ci->diff), repo, ci->parent_tree, ci->commit_tree, &opts)) goto err; - if (commitinfo_getstats(ci) == -1) - goto err; return ci; @@ -575,6 +573,9 @@ writelog(FILE *fp, const git_oid *oid) break; if (!(ci = commitinfo_getbyoid(&id))) break; + /* lookup stats: only required here */ + if (commitinfo_getstats(ci) == -1) + goto err; writelogline(fp, ci); if (cachefile) @@ -596,6 +597,7 @@ writelog(FILE *fp, const git_oid *oid) writefooter(fpfile); fclose(fpfile); } +err: commitinfo_free(ci); } git_revwalk_free(w); -- libgit2 1.1.1